op-service: add configurable client timeout #12074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tynes
approved these changes
Sep 24, 2024
sebastianst
reviewed
Sep 24, 2024
| @@ -66,6 +66,7 @@ func (l *LazyRPC) CallContext(ctx context.Context, result any, method string, ar | |||
| if err := l.dial(ctx); err != nil { | |||
| return err | |||
| } | |||
| fmt.Println("checkpoin 1") | |||
There was a problem hiding this comment.
Oops yea good catch. Cleanup pr here: #12083
Comment on lines
+45
to
+57
| func WithCallTimeout(d time.Duration) RPCOption { | ||
| return func(cfg *rpcConfig) error { | ||
| cfg.callTimeout = d | ||
| return nil | ||
| } | ||
| } | ||
|
|
||
| func WithBatchCallTimeout(d time.Duration) RPCOption { | ||
| return func(cfg *rpcConfig) error { | ||
| cfg.batchCallTimeout = d | ||
| return nil | ||
| } | ||
| } |
There was a problem hiding this comment.
Do I see correctly that these aren't used anywhere (yet)?
Comment on lines
65
to
81
| func NewEngineAPIClient(rpc client.RPC, l log.Logger, evp EngineVersionProvider) *EngineAPIClient { | ||
| return &EngineAPIClient{ | ||
| RPC: rpc, | ||
| log: l, | ||
| evp: evp, | ||
| RPC: rpc, | ||
| log: l, | ||
| evp: evp, | ||
| timeout: time.Second * 5, | ||
| } | ||
| } | ||
|
|
||
| func NewEngineAPIClientWithTimeout(rpc client.RPC, l log.Logger, evp EngineVersionProvider, timeout time.Duration) *EngineAPIClient { | ||
| return &EngineAPIClient{ | ||
| RPC: rpc, | ||
| log: l, | ||
| evp: evp, | ||
| timeout: timeout, | ||
| } | ||
| } |
There was a problem hiding this comment.
You could use the options pattern here instead, by creating a type EngineAPIClientOption func(*EngineAPIClient) and then receiving a variadic parameter of options and applying them. Then you could create a WithTimeout(time.Duration) option.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
NewEngineAPIClientWithTimeoutwhich allows for a configurable timeout parameter to be passed. Useful for testing outlier engine api calls in the replayor execution client benchmarking tool(h/t @danyalprout)