op-challenger: Release agent resources once game is complete #11820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajsutton
requested review from
tynes and
Inphi
and removed request for
tynes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a player detects that a game is now complete, replace the
actfunction with a no-op so that the agent resources (including the trace provider etc) can be GC'd. We already use a no-opactfunction for games that are completed when the challenger first starts up. Without this the agent resources are only released when the game drops out of the game window after 28 days which makes it look like the challenger has a memory leak as memory increases for the first 28 days of operation before levelling out.Tests
Updated unit tests.
Metadata