Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slim down contracts-bedrock package #11723

Merged
merged 2 commits into from
Sep 4, 2024
Merged

Conversation

mslipper
Copy link
Collaborator

@mslipper mslipper commented Sep 3, 2024

The contracts-bedrock package was over 2GB in size, mostly because it contained the Git repository. It also supported multiple platforms, which would lead to costly recompilation steps every time the image was used on a different platform (e.g., OSX).

The PR updates the Dockerfile to no longer ship the Git repo. It also updates the Debian base image to a more modern, slimmed down version. The new image is <1G in size.

Copy link
Contributor

@tynes tynes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea on how to remove the whole .git directory. Wondering how you would feel about the future of the Dockerfile.packages. To be honest i think it should live in contracts-bedrock but no need to do that in this PR

docker-bake.hcl Outdated Show resolved Hide resolved
The contracts-bedrock package was over 2GB in size, mostly because it contained the Git repository. It also supported multiple platforms, which would lead to costly recompilation steps every time the image was used on a different platform (e.g., OSX).

The PR updates the Dockerfile to no longer ship the Git repo. It also updates the Debian base image to a more modern, slimmed down version. The new image is <1G in size.
@mslipper mslipper added this pull request to the merge queue Sep 4, 2024
Merged via the queue into develop with commit 2f10fb7 Sep 4, 2024
56 checks passed
@mslipper mslipper deleted the feat/contracts-bedrock-size branch September 4, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants