-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cannon: Fix stack patching #11632
Merged
Merged
cannon: Fix stack patching #11632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And add `memprofilerate=0` to envp
protolambda
reviewed
Aug 28, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #11632 +/- ##
===========================================
+ Coverage 80.81% 80.99% +0.17%
===========================================
Files 32 32
Lines 2466 2473 +7
===========================================
+ Hits 1993 2003 +10
+ Misses 396 394 -2
+ Partials 77 76 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Co-authored-by: protolambda <[email protected]>
mbaxter
reviewed
Aug 28, 2024
mbaxter
approved these changes
Aug 28, 2024
Co-authored-by: mbaxter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the base stack pointer of the op-program.
Also adds the
memprofilerate=0
environment variable to all patched programs.Setting
memprofilerate
avoids floating point operations within the Go runtime. We should be able to disable Go specific patches with this change, but this will be done on a later PR.fixes: #11660