-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
op-node: read BlockTime, SeqWindowSize from superchain-registry configs #11172
Conversation
f031dcc
to
7ba2782
Compare
68aacdd
to
0c39c03
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #11172 +/- ##
============================================
+ Coverage 60.69% 79.69% +18.99%
============================================
Files 20 12 -8
Lines 1781 1246 -535
Branches 71 0 -71
============================================
- Hits 1081 993 -88
+ Misses 667 220 -447
Partials 33 33
Flags with carried forward coverage won't be shown. Click here to find out more. |
Once this is merged, we can go back and update the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change LGTM. We have some tests already that check a few frozen configs against what the registry generates, and those still pass, so the values are correctly set.
Description
BlockTime
andSequencerWindowSize
fromsuperchain.ChainConfig
duringLoadOPStackRollupConfig
Additional Context
Fixes ethereum-optimism/superchain-registry#390