Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op-node: read BlockTime, SeqWindowSize from superchain-registry configs #11172

Merged
merged 3 commits into from
Jul 18, 2024

Conversation

bitwiseguy
Copy link
Contributor

@bitwiseguy bitwiseguy commented Jul 17, 2024

Description

  • Update the version of go superchain-registry/superchain module import
  • Update op-node to read BlockTime and SequencerWindowSize from superchain.ChainConfig during LoadOPStackRollupConfig

Additional Context

Fixes ethereum-optimism/superchain-registry#390

@bitwiseguy bitwiseguy changed the title Read from updated superchain-registry configs op-node: read BlockTime, SeqWindowSize from superchain-registry configs Jul 18, 2024
Copy link

codecov bot commented Jul 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.69%. Comparing base (c55ade0) to head (4ff66bb).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #11172       +/-   ##
============================================
+ Coverage    60.69%   79.69%   +18.99%     
============================================
  Files           20       12        -8     
  Lines         1781     1246      -535     
  Branches        71        0       -71     
============================================
- Hits          1081      993       -88     
+ Misses         667      220      -447     
  Partials        33       33               
Flag Coverage Δ
cannon-go-tests 79.69% <ø> (ø)
chain-mon-tests ?
sdk-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 8 files with indirect coverage changes

@bitwiseguy bitwiseguy marked this pull request as ready for review July 18, 2024 02:25
@bitwiseguy bitwiseguy requested a review from geoknee July 18, 2024 02:25
op-node/rollup/superchain.go Outdated Show resolved Hide resolved
@geoknee
Copy link
Contributor

geoknee commented Jul 18, 2024

Once this is merged, we can go back and update the validation module in the superchain-registry to pull in these changes.

Copy link
Contributor

@protolambda protolambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change LGTM. We have some tests already that check a few frozen configs against what the registry generates, and those still pass, so the values are correctly set.

@protolambda protolambda added this pull request to the merge queue Jul 18, 2024
Merged via the queue into develop with commit 4b80464 Jul 18, 2024
63 checks passed
@protolambda protolambda deleted the ss/read-params-from-scr branch July 18, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make sure downstream software reads block_time and seq_window_size
4 participants