-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
op-supervisor: Load the starting block from log db #11090
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #11090 +/- ##
========================================
Coverage 60.69% 60.69%
========================================
Files 20 20
Lines 1781 1781
Branches 71 71
========================================
Hits 1081 1081
Misses 667 667
Partials 33 33
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this. Left a comment suggestion how to make this fit in better with the need to handle only some logs from a block being written before shutdown.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks. Just one small tweak to improve the formatting of the comment.
Ah also can you run gofmt please? CI is failing with:
|
49647f2
Load the starting block from log db