Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op-supervisor: Load the starting block from log db #11090

Merged
merged 8 commits into from
Jul 9, 2024

Conversation

r4525532
Copy link
Contributor

@r4525532 r4525532 commented Jul 8, 2024

Load the starting block from log db

Copy link

codecov bot commented Jul 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.69%. Comparing base (d4a22a7) to head (c416e97).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #11090   +/-   ##
========================================
  Coverage    60.69%   60.69%           
========================================
  Files           20       20           
  Lines         1781     1781           
  Branches        71       71           
========================================
  Hits          1081     1081           
  Misses         667      667           
  Partials        33       33           
Flag Coverage Δ
cannon-go-tests 79.69% <ø> (ø)
chain-mon-tests 27.14% <ø> (ø)
sdk-tests 16.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@ajsutton ajsutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. Left a comment suggestion how to make this fit in better with the need to handle only some logs from a block being written before shutdown.

op-supervisor/supervisor/backend/db/db.go Outdated Show resolved Hide resolved
@r4525532 r4525532 requested a review from ajsutton July 8, 2024 05:05
Copy link
Contributor

@ajsutton ajsutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks. Just one small tweak to improve the formatting of the comment.

op-supervisor/supervisor/backend/backend.go Outdated Show resolved Hide resolved
@ajsutton
Copy link
Contributor

ajsutton commented Jul 8, 2024

Ah also can you run gofmt please? CI is failing with:

op-supervisor/supervisor/backend/backend.go:60: File is not `goimports`-ed (goimports)
                checkPointBlock, _ ,err := logDB.ClosestBlockInfo(math.MaxUint64)

@r4525532 r4525532 requested a review from a team as a code owner July 9, 2024 00:39
@r4525532 r4525532 requested a review from mbaxter July 9, 2024 00:39
@ajsutton ajsutton enabled auto-merge July 9, 2024 00:58
@ajsutton ajsutton added this pull request to the merge queue Jul 9, 2024
Merged via the queue into ethereum-optimism:develop with commit 49647f2 Jul 9, 2024
58 of 60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants