op-program: Treat reaching the safe head as a success not a failure. #10982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current fault dispute rules are that the safe head is extended to the end of the trace.
protolambda
changed the title
ajsutton
requested review from
bitwiseguy and
protolambda
and removed request for
bitwiseguy
protolambda
approved these changes
Jun 22, 2024
rdovgan
pushed a commit
to rdovgan/optimism
that referenced
this pull request
Jun 24, 2024
…e. (ethereum-optimism#10982) Current fault dispute rules are that the safe head is extended to the end of the trace.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Current fault dispute rules are that the safe head is extended to the end of the trace. In #10971 this behaviour was changed to return an error which is translated to mean the claimed output root is invalid. Honest challengers are then unable to defend their honest claim that the safe head was reached because the program results in an error.
Should fix the cannon e2e tests.