-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
op-node: attributes-handler with events #10947
Conversation
Semgrep found 1 Named return arguments to functions must be appended with an underscore ( Semgrep found 1 Malformed revert statement style. Ignore this finding from sol-style-malformed-revert.Semgrep found 1 Inputs to functions must be prepended with an underscore ( |
f256b91
to
f67329a
Compare
f67329a
to
d9ecb34
Compare
d9ecb34
to
608a0ff
Compare
Wait for dependency PR and plasma-test updates before merging |
608a0ff
to
319d4bb
Compare
Rebased on develop. Also, looks like there's something wrong with op-program refactor, it's running out of events to process. Some state-change is not feeding back into the program for continuation. Will split it out of this PR and debug it tomorrow. |
319d4bb
to
d039b39
Compare
d039b39
to
6358451
Compare
Semgrep found 1 Malformed revert statement style. Ignore this finding from sol-style-malformed-revert. |
2e73934
to
17a54ef
Compare
6358451
to
dd444db
Compare
96fb214
to
03fcfc2
Compare
03fcfc2
to
8275a0a
Compare
8275a0a
to
8ec52c7
Compare
Ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just a suggestion around the e2e tests.
* op-node: event handling on block attributes todo * op-node: update plasma step to no longer hardcode pipeline stepping
Description
One more step towards separating every components with events.
This turns the
AttributesHandler
into a Deriver, processing and emitting events to interact with the other things around it.Depends on #10971Tests
After we have events, there's no single synchronous notion of a derivation-step anymore. Thus in the e2e action tests I instead fixed up tests to run the derivation till a certain event, rather than an arbitrary step that leaks internal behavior of the derivation progression.
Metadata
Fix #10852