op-batcher: Do not retry dial attempts in active l2 providers #10696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrianBland
force-pushed
the
active-provider-no-dial-retries
branch
from
df8ee62
to
47b8453
Compare
sebastianst
requested review from
sebastianst and
protolambda
and removed request for
protolambda
BrianBland
force-pushed
the
active-provider-no-dial-retries
branch
from
47b8453
to
994f549
Compare
sebastianst
approved these changes
May 31, 2024
protolambda
approved these changes
May 31, 2024
Merged
via the queue into
ethereum-optimism:develop
with commit May 31, 2024
61b2b36
62 checks passed
rdovgan
pushed a commit
to rdovgan/optimism
that referenced
this pull request
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Perform simple endpoint dialing in
ActiveL2RollupProvider, as compared to the standard retrying dial flow. This allows dialing to fail quickly, and fall back to the next candidate endpoint, potentially repeating. With the default retry behavior, this will perform 30 attempts with 2 second delays in between attempts, frequently consuming all of the current context's deadline.Tests
No tests added for this change.
Additional context
Add any other context about the problem you're solving.
Metadata
-Related to #10695