Log when a hardfork is first activated

[bitwiseguy]

Description

To give node operators more insight into their chains, we should log when a new hardfork is first activated.

Assumptions

Hardforks must always be activated in the same, sequential order, starting with regolith. Therefore we know upfront what hardfork we should be looking for next based on the current hardfork.

Tests

Added unit tests for new CheckForkActivation function.

Metadata

• Fixes https://github.com/ethereum-optimism/client-pod/issues/606

[coderabbitai]

Walkthrough

Walkthrough

The recent updates in the op-node/rollup package focus on enhancing the handling of blockchain forks. Key changes include the introduction of a new ForkName type, the addition of a nextFork map, and modifications to various structs and functions to incorporate these elements. New methods and tests have been added to manage and verify fork activations, ensuring smoother transitions between different blockchain states.

Changes

File Path	Change Summary
op-node/rollup/types.go	Added ForkName type, constants for forks, nextFork map, updated Config struct, checkFork function, and added fork activation check methods.
op-node/rollup/chain_spec.go	Introduced ForkName type, constants, nextFork map, modified ChainSpec struct, and added CheckForkActivation method for fork activation logic.
op-node/rollup/chain_spec_test.go	Imported slog package, added TestCheckForkActivation function, and included test cases for various hardfork activation scenarios.
op-node/rollup/derive/engine_controller.go	Modified SetUnsafeHead function in EngineController to call CheckForkActivation method of chainSpec.

---

Recent Review Details

Configuration used: .coderabbit.yml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between da8f526 and 23df093.

Files selected for processing (4)

• op-node/rollup/chain_spec.go (3 hunks)
• op-node/rollup/chain_spec_test.go (2 hunks)
• op-node/rollup/derive/engine_controller.go (3 hunks)
• op-node/rollup/types.go (4 hunks)

Files skipped from review as they are similar to previous changes (4)

• op-node/rollup/chain_spec.go
• op-node/rollup/chain_spec_test.go
• op-node/rollup/derive/engine_controller.go
• op-node/rollup/types.go

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 2

[coderabbitai]

Actionable comments posted: 1

[coderabbitai]

Actionable comments posted: 1