-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
op-e2e: Enable Fjord / RIP-7212 Test #10260
Conversation
WalkthroughWalkthroughThe recent updates involve enhancing the time configuration setup in the genesis block of an operation chain by introducing Changes
Recent Review DetailsConfiguration used: .coderabbit.yml Files ignored due to path filters (2)
Files selected for processing (2)
Files skipped from review as they are similar to previous changes (2)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just needs op-geth dependency update, I created tag v1.101311.1-rc.1
.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #10260 +/- ##
===========================================
+ Coverage 42.20% 42.40% +0.19%
===========================================
Files 52 73 +21
Lines 4319 4830 +511
Branches 670 766 +96
===========================================
+ Hits 1823 2048 +225
- Misses 2390 2676 +286
Partials 106 106
Flags with carried forward coverage won't be shown. Click here to find out more. |
e062e73
Description
This PR allows us to enable Fjord in the e2e tests for op-geth and adds some sanity checks for RIP-7212. There is much more comprehensive testing here.
Tests
Added the following test cases: