Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op-e2e: Enable Fjord / RIP-7212 Test #10260

Merged
merged 2 commits into from
Apr 23, 2024

Conversation

danyalprout
Copy link
Contributor

@danyalprout danyalprout commented Apr 23, 2024

Description

This PR allows us to enable Fjord in the e2e tests for op-geth and adds some sanity checks for RIP-7212. There is much more comprehensive testing here.

Tests
Added the following test cases:

  • Pre-Fjord Activation
    • Valid request fails
    • Invalid request fails
  • Post-Fjord Activation
    • Valid request succeeds
    • Invalid request fails

@danyalprout danyalprout requested a review from a team as a code owner April 23, 2024 00:43
Copy link
Contributor

coderabbitai bot commented Apr 23, 2024

Walkthrough

Walkthrough

The recent updates involve enhancing the time configuration setup in the genesis block of an operation chain by introducing FjordTime. Additionally, new test functions have been added to op_geth_test.go to test scenarios related to a specific precompile contract, both before and after the FjordTime implementation. These changes aim to improve time-related functionality and ensure comprehensive testing of precompiled contracts under various conditions.

Changes

Files Summary of Changes
.../genesis/genesis.go Added FjordTime declaration in NewL2Genesis using config.FjordTime(block.Time()).
op-e2e/op_geth_test.go Introduced new test functions TestPreFjord and TestFjord to test scenarios related to a precompile contract.

Recent Review Details

Configuration used: .coderabbit.yml
Review profile: CHILL

Commits Files that changed from the base of the PR and between 0d221da and ba44306.
Files ignored due to path filters (2)
  • go.mod is excluded by !**/*.mod
  • go.sum is excluded by !**/*.sum
Files selected for processing (2)
  • op-chain-ops/genesis/genesis.go (1 hunks)
  • op-e2e/op_geth_test.go (2 hunks)
Files skipped from review as they are similar to previous changes (2)
  • op-chain-ops/genesis/genesis.go
  • op-e2e/op_geth_test.go

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@danyalprout danyalprout marked this pull request as draft April 23, 2024 00:48
Copy link
Member

@sebastianst sebastianst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just needs op-geth dependency update, I created tag v1.101311.1-rc.1.

@danyalprout danyalprout marked this pull request as ready for review April 23, 2024 14:24
Copy link

codecov bot commented Apr 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.40%. Comparing base (0d221da) to head (ba44306).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #10260      +/-   ##
===========================================
+ Coverage    42.20%   42.40%   +0.19%     
===========================================
  Files           52       73      +21     
  Lines         4319     4830     +511     
  Branches       670      766      +96     
===========================================
+ Hits          1823     2048     +225     
- Misses        2390     2676     +286     
  Partials       106      106              
Flag Coverage Δ
cannon-go-tests 82.29% <ø> (ø)
chain-mon-tests 27.14% <ø> (ø)
common-ts-tests 26.72% <ø> (ø)
contracts-ts-tests 12.25% <ø> (ø)
core-utils-tests 44.03% <ø> (?)
sdk-tests 40.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 21 files with indirect coverage changes

@sebastianst sebastianst added this pull request to the merge queue Apr 23, 2024
Merged via the queue into ethereum-optimism:develop with commit e062e73 Apr 23, 2024
70 of 72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants