-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
op-e2e: Refactor for asterisc e2e #10214
op-e2e: Refactor for asterisc e2e #10214
Conversation
f0be622
to
211d374
Compare
WalkthroughThe recent updates involve standardizing naming conventions by renaming functions and struct fields, transitioning from lowercase to uppercase initials. This change enhances code readability and consistency across various files. Additionally, new constructor functions have been introduced for improved struct initialization, and method calls have been adjusted to align with these naming and structural modifications. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
211d374
to
8faf87a
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I suspect we're going to break this on you quite a lot as we don't treat this as a library with a stable API, but I think it's a reasonable thing to do for now. Long term we probably need to find a better way to either build an explicit library with a more stable API or find a way to better separate the asterisc e2e test framework. Worth finding exactly what the pain points are before trying to do that though.
d4706da
Description
Exposes fields and methods for running op-e2e faultproof tests at asterisc repo. Asterisc inherits the structure of output game helper and output cannon helper, so this exposure is necessary.
Added initializer methods to make exposure minimal.