You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Op-e2e has several environment variables that result in some duplication of test runs:
OP_E2E_USE_SPAN_BATCH
OP_E2E_USE_CANYON (not in CI?)
OP_E2E_USE_HTTP
These should be removed: not all op-e2e tests are actually affected by these. Instead, we should parametrize individual test-cases with the settings they need to run with.
The text was updated successfully, but these errors were encountered:
hmm, we probably should have set OP_E2E_USE_CANYON=false for e2e-http and test-external. They've probably gone back to running the canon tests again which isn't particularly helpful.
Is the idea here to only have one e2e job in CI rather than separate ws and http jobs? If we get there, we could probably remove OP_E2E_CANNON_ENABLED as well.
The external client tests probably should stay since the idea there is to plug in something other than op-geth which makes nearly all the tests useful for compatibility testing (though long term it would be good to have a more dedicated set of reference tests).
Op-e2e has several environment variables that result in some duplication of test runs:
OP_E2E_USE_SPAN_BATCH
OP_E2E_USE_CANYON
(not in CI?)OP_E2E_USE_HTTP
These should be removed: not all op-e2e tests are actually affected by these. Instead, we should parametrize individual test-cases with the settings they need to run with.
The text was updated successfully, but these errors were encountered: