Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize op-e2e: do not repeat tests unaffected by hardforks or connection-type #8022

Open
protolambda opened this issue Nov 2, 2023 · 2 comments

Comments

@protolambda
Copy link
Contributor

Op-e2e has several environment variables that result in some duplication of test runs:

  • OP_E2E_USE_SPAN_BATCH
  • OP_E2E_USE_CANYON (not in CI?)
  • OP_E2E_USE_HTTP

These should be removed: not all op-e2e tests are actually affected by these. Instead, we should parametrize individual test-cases with the settings they need to run with.

@ajsutton
Copy link
Contributor

ajsutton commented Nov 2, 2023

hmm, we probably should have set OP_E2E_USE_CANYON=false for e2e-http and test-external. They've probably gone back to running the canon tests again which isn't particularly helpful.

Is the idea here to only have one e2e job in CI rather than separate ws and http jobs? If we get there, we could probably remove OP_E2E_CANNON_ENABLED as well.

The external client tests probably should stay since the idea there is to plug in something other than op-geth which makes nearly all the tests useful for compatibility testing (though long term it would be good to have a more dedicated set of reference tests).

@ImTei
Copy link
Collaborator

ImTei commented Nov 6, 2023

Opened PR for span batch - #8047

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants