Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize span batch e2e test #8047

Merged
merged 2 commits into from
Nov 7, 2023
Merged

Optimize span batch e2e test #8047

merged 2 commits into from
Nov 7, 2023

Conversation

ImTei
Copy link
Collaborator

@ImTei ImTei commented Nov 6, 2023

Description
This issue was raised in #7867 (comment), and is being tracked in #8022.

  • Remove running e2e tests in span batch mode via OP_E2E_USE_SPAN_BATCH env variable
  • Remove span batch e2e CI workflow
  • Parameterize existing e2e tests related to span batch
    • Using op-batcher and checking L2 safe head

@ImTei ImTei requested review from a team as code owners November 6, 2023 05:41
@ImTei ImTei requested a review from mslipper November 6, 2023 05:41
@ImTei ImTei mentioned this pull request Nov 6, 2023
Open
ajsutton
ajsutton approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@ajsutton ajsutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@ajsutton ajsutton added this pull request to the merge queue Nov 7, 2023
Merged via the queue into ethereum-optimism:develop with commit 6c25b1e Nov 7, 2023
57 checks passed
@protolambda protolambda mentioned this pull request Nov 7, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajsutton ajsutton ajsutton approved these changes

@mslipper mslipper Awaiting requested review from mslipper mslipper was automatically assigned from ethereum-optimism/infra-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ImTei @ajsutton