Merge pull request #6767 from ethereum-optimism/08-12-feat_indexer_Pr…

…eallocate_space_for_a_slice_ feat(indexer): Preallocate space for a slice
ethereum-optimism · Aug 15, 2023 · db0e18c · db0e18c
2 parents 6c349fa + 6f87ca8
commit db0e18c
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/indexer/api/routes/deposits.go b/indexer/api/routes/deposits.go
@@ -30,7 +30,7 @@ type DepositResponse struct {
 // TODO this is original spec but maybe include the l2 block info too for the relayed tx
 // FIXME make a pure function that returns a struct instead of newWithdrawalResponse
 func newDepositResponse(deposits []*database.L1BridgeDepositWithTransactionHashes) DepositResponse {
-	var items []DepositItem
+	items := make([]DepositItem, len(deposits))
 	for _, deposit := range deposits {
 		item := DepositItem{
 			Guid: deposit.L1BridgeDeposit.TransactionSourceHash.String(),

diff --git a/indexer/api/routes/withdrawals.go b/indexer/api/routes/withdrawals.go
@@ -43,7 +43,7 @@ type WithdrawalResponse struct {
 
 // FIXME make a pure function that returns a struct instead of newWithdrawalResponse
 func newWithdrawalResponse(withdrawals []*database.L2BridgeWithdrawalWithTransactionHashes) WithdrawalResponse {
-	var items []WithdrawalItem
+	items := make([]WithdrawalItem, len(withdrawals))
 	for _, withdrawal := range withdrawals {
 		item := WithdrawalItem{
 			Guid: withdrawal.L2BridgeWithdrawal.TransactionWithdrawalHash.String(),