contracts-bedrock: move reinitialization test to Initializable.t.sol

ethereum-optimism · Jan 3, 2024 · 95434e0 · 95434e0
1 parent 4b4a398
commit 95434e0
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/packages/contracts-bedrock/test/universal/OptimismMintableERC20Factory.t.sol b/packages/contracts-bedrock/test/universal/OptimismMintableERC20Factory.t.sol
@@ -30,12 +30,6 @@ contract OptimismMintableTokenFactory_Test is Bridge_Initializer {
         assertEq(address(l1OptimismMintableERC20Factory.bridge()), address(l1StandardBridge));
     }
 
-    /// @dev Tests that the proxy cannot be initialized twice.
-    function test_initialize_cannotInitProxy_reverts() external {
-        vm.expectRevert("Initializable: contract is already initialized");
-        l1OptimismMintableERC20Factory.initialize(address(0));
-    }
-
     /// @dev Tests that the implementation cannot be initialized twice.
     function test_initialize_cannotInitImpl_reverts() external {
         address impl = deploy.mustGetAddress("OptimismMintableERC20Factory");

diff --git a/packages/contracts-bedrock/test/vendor/Initializable.t.sol b/packages/contracts-bedrock/test/vendor/Initializable.t.sol
@@ -143,6 +143,14 @@ contract Initializer_Test is Bridge_Initializer {
                 initializedSlotVal: deploy.loadInitializedSlot("L2ERC721Bridge", false)
             })
         );
+        // OptimismMintableERC20Factory
+        contracts.push(
+            InitializeableContract({
+                target: address(l1OptimismMintableERC20Factory),
+                initCalldata: abi.encodeCall(l1OptimismMintableERC20Factory.initialize, (address(l1StandardBridge))),
+                initializedSlotVal: deploy.loadInitializedSlot("OptimismMintableERC20Factory", false)
+            })
+        );
     }
 
     /// @notice Tests that: