Skip to content

Commit

Permalink
ci(ctb): Slither fails only on high severity findings
Browse files Browse the repository at this point in the history
This change implements the information provided in these slither
issues:
crytic/slither#1408
crytic/slither-action#38

Apparently 'fail_pedantic' defaults to true, which overrides the
'exclude_*' settings and causes failures on optimization and
informational severity findings.

As is this config should:
1. Fail only on High severity findings
2. Print Medium severity findings but not fail on them.

This commit also deletes the findings in the slither db which
were less than high severity. They are now simply ignored via this
corrected config.
  • Loading branch information
maurelian committed Apr 14, 2023
1 parent 3c052f2 commit 4adbe76
Show file tree
Hide file tree
Showing 2 changed files with 255 additions and 38,176 deletions.
6 changes: 4 additions & 2 deletions packages/contracts-bedrock/slither.config.json
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
{
"detectors_to_exclude": "assembly-usage,block-timestamp,naming-convention,solc-version,low-level-calls,boolean-equality",
"detectors_to_exclude": "",
"fail_high": true,
"fail_pedantic": false,
"exclude_optimization": true,
"exclude_informational": true,
"exclude_low": true,
"exclude_medium": true,
"exclude_high": false,
"solc_disable_warnings": false,
"hardhat_ignore_compile": false,
"disable_color": false,
Expand Down
Loading

0 comments on commit 4adbe76

Please sign in to comment.