Disable access to pending txs from filters + subscriptions #118
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently op-stack chains can leak tx pool contents on shared nodes using two methods:
eth_newPendingTransactionFilter
and subsequent calls toeth_getFilterChanges
eth_subscribe
tonewPendingTransactions
This PR disables these two methods by default (returning an error:
pending tx filters are disabled
). It also adds a new flag:--rollup.allowpendingtxfilters
which optionally enables them.Tests
Tested running geth locally. Without the option:
With the
--rollup.allowpendingtxfilters
option:Additional context
https://status.base.org/incidents/m9fnx4p3bhp5