Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: base l1 contract addresses #571

Merged

Conversation

TheArhaam
Copy link
Contributor

@TheArhaam TheArhaam commented Nov 14, 2024

Description

This PR updates the Base L1 contract addresses which was causing errors while fetching message status from the CrossChainMessenger. The official base contract addresses can be found here

@TheArhaam TheArhaam requested a review from a team as a code owner November 14, 2024 12:41
Copy link

netlify bot commented Nov 14, 2024

Deploy Preview for storybook-component-library canceled.

Name Link
🔨 Latest commit 8b3cae9
🔍 Latest deploy log https://app.netlify.com/sites/storybook-component-library/deploys/673b890e252f010008201d1d

tremarkley
tremarkley previously approved these changes Nov 14, 2024
@tremarkley tremarkley dismissed their stale review November 14, 2024 19:54

checking with team on changes

Copy link
Contributor

@tremarkley tremarkley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the sdk will be officially deprecated in Q1 2025. See the docs on how to migrate away from it here: https://docs.optimism.io/builders/notices/sdk-deprecation

@nitaliano
Copy link
Collaborator

@TheArhaam before we merge this in could you add a changeset on the PR? you can run pnpm changeset from the root of the repo and we can add a patch for this update so we can get it published to npm

@TheArhaam
Copy link
Contributor Author

Hey @nitaliano, added the changeset, let me know if that's okay and if anything else is required. Thanks!

@nitaliano
Copy link
Collaborator

yup all good thanks for the PR @TheArhaam

@nitaliano nitaliano merged commit 5e55ee3 into ethereum-optimism:main Nov 18, 2024
7 checks passed
@github-actions github-actions bot mentioned this pull request Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

op sdk - Unable to get withdrawal status
3 participants