Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(viem): separated L2ToL2CDM and CrossL2Inbox abstractions #496

Merged
merged 7 commits into from
Oct 9, 2024

Conversation

hamdiallam
Copy link
Contributor

@hamdiallam hamdiallam commented Oct 9, 2024

With the latest changes to the CDM, the CrossL2Inbox & L2ToL2CDM abstractions can be completly seperated

  1. Seperate action & utils between the two contracts
  2. Recipt:Messages is 1:many so the function interfaces should represent that when decoding the receipts
  3. Relayed message decoding should cover both successful & failed messages
  4. Add to the tests to make sure the cross chain calls are actually relayed (not failed)

Future Pull Request

  • Viem actions to execute logs directly for users not using the L2CDM and directly consuming a message identifier & payload

Copy link

cloudflare-workers-and-pages bot commented Oct 9, 2024

Deploying superchain-paymaster-nft-mint-example with  Cloudflare Pages  Cloudflare Pages

Latest commit: 7d99717
Status: ✅  Deploy successful!
Preview URL: https://11f1132d.superchain-paymaster-nft-mint-example.pages.dev
Branch Preview URL: https://10-09-fix-viem-to-use-latest.superchain-paymaster-nft-mint-example.pages.dev

View logs

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @hamdiallam and the rest of your teammates on Graphite Graphite

Copy link

netlify bot commented Oct 9, 2024

Deploy Preview for op-dapp-console-preview ready!

Name Link
🔨 Latest commit 7d99717
🔍 Latest deploy log https://app.netlify.com/sites/op-dapp-console-preview/deploys/6706d78c820ab7000880f132
😎 Deploy Preview https://deploy-preview-496--op-dapp-console-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 9, 2024

Deploy Preview for kyc-optimism-io-faq ready!

Name Link
🔨 Latest commit 7d99717
🔍 Latest deploy log https://app.netlify.com/sites/kyc-optimism-io-faq/deploys/6706d78c5047820008b95c18
😎 Deploy Preview https://deploy-preview-496--kyc-optimism-io-faq.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 9, 2024

Deploy Preview for storybook-component-library canceled.

Name Link
🔨 Latest commit 7d99717
🔍 Latest deploy log https://app.netlify.com/sites/storybook-component-library/deploys/6706d78cac3e700008a25007

@hamdiallam hamdiallam force-pushed the 10-09-fix_viem_to_use_latest_abstractions branch from b1b74ea to c6de7f1 Compare October 9, 2024 16:42
@hamdiallam hamdiallam marked this pull request as ready for review October 9, 2024 16:43
@hamdiallam hamdiallam requested a review from a team as a code owner October 9, 2024 16:43
@hamdiallam hamdiallam changed the title fix: viem to use the latest abstractions fix: viem, seperated L2ToL2CDM and CrossL2Inbox abstractions Oct 9, 2024
@hamdiallam hamdiallam changed the title fix: viem, seperated L2ToL2CDM and CrossL2Inbox abstractions fix(viem): seperated L2ToL2CDM and CrossL2Inbox abstractions Oct 9, 2024
@hamdiallam hamdiallam changed the title fix(viem): seperated L2ToL2CDM and CrossL2Inbox abstractions fix(viem): separated L2ToL2CDM and CrossL2Inbox abstractions Oct 9, 2024
@hamdiallam hamdiallam enabled auto-merge (squash) October 9, 2024 19:21
@hamdiallam hamdiallam merged commit 9954f3f into main Oct 9, 2024
19 checks passed
@hamdiallam hamdiallam deleted the 10-09-fix_viem_to_use_latest_abstractions branch October 9, 2024 19:25
@github-actions github-actions bot mentioned this pull request Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants