Update create-l2-rollup.mdx #824
Conversation
WalkthroughThe recent changes enhance the configuration options for batchers and proposers in the Optimism framework. Key updates include adjustments to the Changes
Possibly related issues
Recent review detailsConfiguration used: .coderabbit.yaml Files selected for processing (1)
Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
✅ Deploy Preview for docs-optimism ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (1)
pages/builders/chain-operators/tutorials/create-l2-rollup.mdx (1)
664-670: Clarify the explanation for--max-channel-duration.The change to
--max-channel-duration=25is correct. The explanation in the callout is clear, but consider adding a brief example to illustrate the impact of setting this parameter low versus high.- When it is high, transactions are written to L1 less frequently and the batcher spends less ETH. + For example, when set to 25, transactions are written to L1 less frequently, reducing ETH expenditure by the batcher.
Description
Removed
--rpc.port=8547fromop-node:Use the default value to align with the JSON-RPC API documentation.
Flag description:
--rpc.port value(default: 9545) ($OP_NODE_RPC_PORT)RPC listening port.
Changed
--max-channel-durationforop-batcher:Updated
--max-channel-duration=1to--max-channel-duration=25, referencing the corresponding configuration value fromop-sepolia.Added link target for
--max-channel-duration=n:Added a link to "Set Your OP_BATCHER_MAX_CHANNEL_DURATION" to provide relevant recommendations.
Updated
op-proposercommand for L1StandardBridgeProxy address:Changed the command from
cat deployments/getting-started/L1StandardBridgeProxy.json | jq -r .addressto
cat ../packages/contracts-bedrock/deployments/getting-started/.deploy | jq -r .L2OutputOracleProxyas the previous command was no longer valid.
Updated command to retrieve L1StandardBridgeProxy address:
Changed the command from
cat deployments/getting-started/L1StandardBridgeProxy.json | jq -r .addressto
cat deployments/getting-started/.deploy | jq -r .L1StandardBridgeProxydue to the previous command becoming invalid.
Tests
Please describe any tests you've added. If you've added no tests, or left important behavior untested, please explain why not.
Additional context
Add any other context about the problem you're solving.
Metadata