adding bedrocks activation time #1069
Conversation
✅ Deploy Preview for docs-optimism ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Caution Review failedThe pull request is closed. WalkthroughThe pull request introduces updates to the documentation regarding network upgrades, specifically adding a new section for the Bedrock upgrade. This section outlines the transition to a modular architecture, which separates the consensus, execution, and settlement layers. Additionally, the network upgrades table has been updated to include the Bedrock upgrade, along with its activation details. Changes to the Changes
Assessment against linked issues
Possibly related PRs
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (1)
pages/builders/node-operators/network-upgrades.mdx (1)
116-119: LGTM! Consider adding specification link for consistencyThe content is well-written and properly formatted. However, for consistency with other upgrade sections, consider adding a link to the Bedrock specifications, similar to how other sections link to their respective specification documents.
Apply this change to the header:
-### Bedrock +### [Bedrock](https://specs.optimism.io/protocol/bedrock/overview.html)
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (2)
pages/builders/node-operators/network-upgrades.mdx(2 hunks)words.txt(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- words.txt
🧰 Additional context used
📓 Path-based instructions (1)
pages/builders/node-operators/network-upgrades.mdx (1)
Pattern **/*.mdx: "ALWAYS review Markdown content THOROUGHLY with the following criteria:
- Use proper nouns in place of personal pronouns like 'We' and 'Our' to maintain consistency in communal documentation.
- Avoid gender-specific language and use the imperative form.
- Monitor capitalization for emphasis. Avoid using all caps, italics, or bold for emphasis.
- Ensure proper nouns are capitalized in sentences.
- Apply the Oxford comma.
- Use proper title case for buttons, tab names, page names, and links. Sentence case should be used for body content and short phrases, even in links.
- Use correct spelling and grammar at all times (IMPORTANT).
- For H1, H2, and H3 headers:
- Use sentence case, capitalizing only the first word.
- Preserve the capitalization of proper nouns, technical terms, and acronyms as defined in the 'nouns.txt' file located in the root directory of the project.
- Do not automatically lowercase words that appear in the 'nouns.txt' file, regardless of their position in the header.
- Flag any headers that seem to inconsistently apply these rules for manual review.
- When reviewing capitalization, always refer to the 'nouns.txt' file for the correct capitalization of proper nouns and technical terms specific to the project.
"
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
pages/builders/node-operators/network-upgrades.mdx (1)
31-31: Fix URL formatting in the tableThe governance approval URL should be wrapped in angle brackets for consistency with Markdown standards.
Apply this change:
-| Bedrock | (https://gov.optimism.io/t/final-upgrade-1-bedrock-protocol-upgrade-v2/5548) | Tue Jun 06 2023 16:28:23 UTC (`1686079703`) at block `105235063` | N/A | +| Bedrock | <https://gov.optimism.io/t/final-upgrade-1-bedrock-protocol-upgrade-v2/5548> | Tue Jun 06 2023 16:28:23 UTC (`1686079703`) at block `105235063` | N/A |🧰 Tools
🪛 GitHub Check: lint
[warning] 31-31:
Don’t use literal URLs without angle brackets
[warning] 31-31:
Misaligned table fence
[warning] 31-31:
Misaligned table fence
[warning] 31-31:
Misaligned table fence
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (1)
pages/builders/node-operators/network-upgrades.mdx(2 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
pages/builders/node-operators/network-upgrades.mdx (1)
Pattern **/*.mdx: "ALWAYS review Markdown content THOROUGHLY with the following criteria:
- Use proper nouns in place of personal pronouns like 'We' and 'Our' to maintain consistency in communal documentation.
- Avoid gender-specific language and use the imperative form.
- Monitor capitalization for emphasis. Avoid using all caps, italics, or bold for emphasis.
- Ensure proper nouns are capitalized in sentences.
- Apply the Oxford comma.
- Use proper title case for buttons, tab names, page names, and links. Sentence case should be used for body content and short phrases, even in links.
- Use correct spelling and grammar at all times (IMPORTANT).
- For H1, H2, and H3 headers:
- Use sentence case, capitalizing only the first word.
- Preserve the capitalization of proper nouns, technical terms, and acronyms as defined in the 'nouns.txt' file located in the root directory of the project.
- Do not automatically lowercase words that appear in the 'nouns.txt' file, regardless of their position in the header.
- Flag any headers that seem to inconsistently apply these rules for manual review.
- When reviewing capitalization, always refer to the 'nouns.txt' file for the correct capitalization of proper nouns and technical terms specific to the project.
"
🪛 GitHub Check: lint
pages/builders/node-operators/network-upgrades.mdx
[warning] 31-31:
Don’t use literal URLs without angle brackets
[warning] 31-31:
Misaligned table fence
[warning] 31-31:
Misaligned table fence
[warning] 31-31:
Misaligned table fence
🔇 Additional comments (1)
pages/builders/node-operators/network-upgrades.mdx (1)
116-119: LGTM! Clear and well-structured section
The new Bedrock section effectively explains the architectural changes and their benefits. The content follows the documentation guidelines, using proper nouns and maintaining a professional tone.
Description
Fixes #927