Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sdk-deprecation.mdx #1025

Merged
merged 3 commits into from
Oct 25, 2024
Merged

Update sdk-deprecation.mdx #1025

merged 3 commits into from
Oct 25, 2024

Conversation

sbvegan
Copy link
Collaborator

@sbvegan sbvegan commented Oct 24, 2024

Description

Pointing to our developers repo discussion section

@sbvegan sbvegan requested a review from a team as a code owner October 24, 2024 23:02
Copy link

netlify bot commented Oct 24, 2024

Deploy Preview for docs-optimism ready!

Name Link
🔨 Latest commit e960755
🔍 Latest deploy log https://app.netlify.com/sites/docs-optimism/deploys/671ad5c15460e700083b58aa
😎 Deploy Preview https://deploy-preview-1025--docs-optimism.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

coderabbitai bot commented Oct 24, 2024

Warning

Rate limit exceeded

@sbvegan has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 14 minutes and 25 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Files that changed from the base of the PR and between 7519c7d and e960755.

Walkthrough

The document "Deprecation of the Optimism SDK" has been revised to announce the transition to the viem library, effective Q1 2025. It details the necessary migration steps for developers, highlighting breaking changes in transaction estimation, token bridging, and cross-chain communications. The updates include removal timelines for deprecated SDK methods, revised tutorials, and specific instructions for various developer roles. Additionally, a new support resource has been added, directing users to the developer forum while maintaining links to existing support channels.

Changes

File Path Change Summary
pages/builders/notices/sdk-deprecation.mdx Updated to reflect the transition from the Optimism SDK to the viem library, including breaking changes, migration instructions, and support resources.

Possibly related PRs

  • Added banner and notice page for SDK deprecation  #928: This PR directly addresses the deprecation of the Optimism SDK and the transition to the viem library, which aligns with the main PR's focus on updating documentation regarding the same deprecation and migration details.

Suggested reviewers

  • krofax
  • bradleycamacho

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Outside diff range and nitpick comments (3)
pages/builders/notices/sdk-deprecation.mdx (3)

Line range hint 8-9: Use specific project name instead of generic reference

Replace "The project" with "Optimism" to maintain clarity and proper noun usage in communal documentation.

-The project is shifting to the `viem` library
+Optimism is shifting to the `viem` library

Line range hint 28-28: Use imperative form instead of personal pronouns

Replace "We are updating" with an imperative form to maintain consistency in communal documentation.

-We are updating our tutorials to use the `viem` library.
+All tutorials are being updated to use the `viem` library.

Line range hint 39-42: Include alternative package managers and fix indentation

Add npm and yarn commands, and fix code block indentation for better readability.

-    pnpm remove @eth-optimism/sdk
-    pnpm add viem 
+# Using pnpm
+pnpm remove @eth-optimism/sdk
+pnpm add viem
+
+# Using npm
+npm uninstall @eth-optimism/sdk
+npm install viem
+
+# Using yarn
+yarn remove @eth-optimism/sdk
+yarn add viem
📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 1efa7de and a7b085d.

📒 Files selected for processing (1)
  • pages/builders/notices/sdk-deprecation.mdx (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
pages/builders/notices/sdk-deprecation.mdx (1)

Pattern **/*.mdx: "ALWAYS review Markdown content THOROUGHLY with the following criteria:

  • Use proper nouns in place of personal pronouns like 'We' and 'Our' to maintain consistency in communal documentation.
  • Avoid gender-specific language and use the imperative form.
  • Monitor capitalization for emphasis. Avoid using all caps, italics, or bold for emphasis.
  • Ensure proper nouns are capitalized in sentences.
  • Apply the Oxford comma.
  • Use proper title case for headers, buttons, tab names, page names, and links. Sentence case should be used for body content and short phrases, even in links.
  • Use correct spelling and grammar at all times (IMPORTANT).
  • Use sentence case for H1, H2, and H3 headers, capitalizing only the first word and any proper nouns.
  • For all headers (H1, H2, H3), do not change the capitalization of proper nouns; keep them as they are.
    "
🔇 Additional comments (1)
pages/builders/notices/sdk-deprecation.mdx (1)

71-71: Developer forum link addition approved

The addition of the developer forum link aligns with the PR objectives and provides a clear path for developer discussions.

pages/builders/notices/sdk-deprecation.mdx Outdated Show resolved Hide resolved
Copy link
Member

@bradleycamacho bradleycamacho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd phrase it slightly different (see suggestion). But approved otherwise; feel free to merge after any fixes!

pages/builders/notices/sdk-deprecation.mdx Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants