Skip to content

Commit

Permalink
Rem obsolete TODOs
Browse files Browse the repository at this point in the history
  • Loading branch information
ognjenkurtic committed Jul 26, 2024
1 parent 5ba07c3 commit 47ef994
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 13 deletions.
9 changes: 0 additions & 9 deletions examples/bri-3/src/bri/state/agents/state.agent.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,15 +9,6 @@ import { Witness } from '../../zeroKnowledgeProof/models/witness';
import { StateTreeLeafValueContent } from '../models/stateTreeLeafValueContent';
import { LEAF_STATE_VALUE_NOT_FOUND_ERR_MESSAGE } from '../bpiAccounts/api/err.messages';

// TODO: #741 We should follow this approach everywhere for storage
// https://www.prisma.io/docs/guides/performance-and-optimization/prisma-client-transactions-guide#scenario-pre-computed-ids-and-the-transaction-api
// We precompute Ids, collect all storage actions from the relevant storage agents
// and then execute a single prisma transaction at the end of the command handler
// Best way to achieve this is to have a provider called i.e dbContext, which is scoped as REQUEST
// that is injected in every agent and serves as the place where we collect all the db actions created by storage agents which are invoked by
// by regular agents. This dbContext is in the end passed to prisma.transaction call, so that db actions are executed in order
// as part of a single transaction.

// TODO: #742 MIL5 - Introduce unit tests once https://github.com/demonsters/prisma-mock implemented
@Injectable()
export class StateAgent {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -227,10 +227,6 @@ export class TransactionAgent {
return txResult;
}

// TODO: #744 Only for the purposes of temporary convention
// to connect worksteps with circuits on the file system.
// Format is: <path_from_env>/<workstep_name_in_snake_case>_<predefined_suffix>.
// Will be ditched completely as part of milestone 5.
private constructCircuitPathsFromWorkstepName(name: string): {
circuitProvingKeyPath: string;
circuitVerificatioKeyPath: string;
Expand Down

0 comments on commit 47ef994

Please sign in to comment.