This repository has been archived by the owner on Apr 24, 2022. It is now read-only.
Stratum: Support for set_target and set_difficulty #2191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adding support for set_target reported by flypool.org * Adding support for set_difficulty reported from f2pool.com in STRATRUM mode. * f2pool.com still causes a crash tho, because of a division by zero, which needs some investigation in what variables are not set to a usable default value.
|
Thanks for making the PR, I was just about to upstream my local patch. I'll add that c3pool.com kicks miners that don't support set_target (or possibly fixed share difficulty), so this is a pretty important feature for me. |
|
Pools should do a much better job of sticking to some form of standard! |
Stoom
reviewed
Apr 23, 2021
|
|
||
| m_session->nextWorkBoundary = h256(dev::getTargetFromDiff(nextWorkDifficulty)); | ||
| } | ||
| } | ||
| else |
There was a problem hiding this comment.
Fun fact, this else never could execute before...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in STRATRUM mode.
by zero, which needs some investigation in what variables
are not set to a usable default value.