Skip to content
This repository has been archived by the owner on Apr 24, 2022. It is now read-only.

Fix crash issue on latest nvidia windows drivers #1843

Merged
merged 1 commit into from
Feb 19, 2019

Conversation

smurfy
Copy link
Collaborator

@smurfy smurfy commented Feb 8, 2019

Latest windows nvidia drivers do not ship opencl drivers with them anymore. Which causes hwmon to crash enumerating ocl platforms.

This PR is against 0.17, but i can change that if needed.

Resolves #1841

@AndreaLanfranchi
Copy link
Collaborator

What if you launch with -U ?
It should completely bypass OpenCL detection

@smurfy
Copy link
Collaborator Author

smurfy commented Feb 8, 2019

What if you launch with -U ?
It should completely bypass OpenCL detection

does not help, as you see in the code, nvml wrapper will call opencl methods to create its mapping.
cl::Platform::get(&platforms); causes an exception to be thrown if no platform is detected.

My changes fixes that.

edit: only thing which will "help" is if its compiled without opencl support at all :)

@AndreaLanfranchi
Copy link
Collaborator

Ok. I see the point.

@smurfy
Copy link
Collaborator Author

smurfy commented Feb 8, 2019

Is target branch ok or should i do it agains master?

@AndreaLanfranchi
Copy link
Collaborator

@smurfy the branch is ok.
Latest master does not have this problem anymore as wrapnvml.cpp has been modified to not require any correspondence by card id. It does it directly with PCI id.
Hopefully @chfast will release 0.18 anytime soon.

@ddobreff ddobreff self-requested a review February 10, 2019 18:28
@chfast chfast self-assigned this Feb 11, 2019
@chfast chfast merged commit 276722c into ethereum-mining:release/0.17 Feb 19, 2019
@chfast
Copy link
Contributor

chfast commented Feb 28, 2019

This fix is not needed in the master branch? I cannot find this piece of code.

@AndreaLanfranchi
Copy link
Collaborator

@chfast
not needed. Read my earlier comment.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants