Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add all lower nibiru envs #6118

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

cgilbe27
Copy link

No description provided.

Copy link

You successfully submitted a PR! Due to the amount of PRs coming in: we will only look at PRs that the CI is happy with. We can also not hold your hand getting the CI green - just look how others that where merged did it and RTFM. So as long as there is any CI check that reports an error - no human will look at this. You might be able to ask for some support after supporting the project - e.g. by sending funds to lists.eth. When you fixed things after a requested change - then you also need to (re-)request a review.

@cgilbe27 cgilbe27 marked this pull request as draft October 31, 2024 18:23
@cgilbe27 cgilbe27 marked this pull request as ready for review November 5, 2024 15:36
@cgilbe27
Copy link
Author

cgilbe27 commented Nov 5, 2024

This MR is ready

Copy link
Member

@ligi ligi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you cannot delete chains - only mark them deprecated. This is important to prevent replay attacks

@cgilbe27 cgilbe27 requested a review from ligi November 10, 2024 20:17
@cgilbe27
Copy link
Author

you cannot delete chains - only mark them deprecated. This is important to prevent replay attacks

Addressed

Copy link
Member

@ligi ligi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RPC chainId (7220) does not match chainId from json (6920)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants