Fix Google Maps api load order + provide an extra callback for devs to hook into #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #294
Fixes the load order for Google Maps api. Since it uses a passed callback in the URL, the callback needs to be added first, hence changing to registerScript to force the order (Craft doesn't seem to have a mechanism to specify assets order except AssetBundles).
Also added an onload event to provide an extra callback with "onload" since the code already provides the callback to add the markers. By adding this callback, we are guaranteed that our extra code executes after the Google Maps API is loaded and that the initial callback is executed.