Refactor slave grouping to be more ergonomic #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimy-byerley
pushed a commit
to jimy-byerley/ethercrab
that referenced
this pull request
May 12, 2023
* Return `&dyn Bikeshed` instead of `&mut dyn Bikeshed` * Remove requirement to implement `SlaveGroupContainer` * Remove SlaveGroup::as_mut
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SlaveGroupContainertrait is not longer required to be implemented and is removed.&dyn SlaveGroupHandleto be returned. This is a sealed trait only implemented forSlaveGroups and allows some internal refactors by erasing the const generics fromSlaveGroup.SlaveStorageis removed. Slave devices for a group are now simply stored in aheapless::Vec.Client::initnow defines the max number of groups, not the max number of slave devices, and should match the number of unique groups passed in (struct fields, array/tuple items, etc)Closes #35 -
SlaveGroupContaineris gone now.