Fix abort code parsing #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was causing the first 4 bytes in an aborted request (which contain the error code) to be eaten by what should just be the header. This meant that the data read was 4 bytes ahead of where it should be, causing the error code to be read as 0x00000000.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abort codes would fail to parse when an expedited download was aborted. The return type would steal the abort code bytes as its payload, leaving the
AbortCodeparsing with zeroes. This is fixed now.Abort codes can now never fail to parse. Instead, an unknown abort code will be parsed as
AbortCode::Unknown(u32)and displayed like0x12345678: Unknown codeCloses #27