Add a blocking Windows TX/RX function #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently spins waiting for TX/RX but it's showing a huge improvement in RTT.
So we can filter out self-sent frames
Massively improved performance (although Windows is still rubbish for RT stuff)
jamwaffles
added a commit
that referenced
this pull request
Nov 17, 2024
* Return `ReceiveAction` from `receive_frame` So we can filter out self-sent frames * Rewrite Windows TX/RX driver to use the `pcap` crate Massively improved performance (although Windows is still rubbish for RT stuff) * Add Windows example demonstrating some perf tweaks * Deprecate Windows `tx_rx_task` * Give EEPROM reads a little bit more breathing room
jamwaffles
added a commit
that referenced
this pull request
Nov 17, 2024
* Return `ReceiveAction` from `receive_frame` So we can filter out self-sent frames * Rewrite Windows TX/RX driver to use the `pcap` crate Massively improved performance (although Windows is still rubbish for RT stuff) * Add Windows example demonstrating some perf tweaks * Deprecate Windows `tx_rx_task` * Give EEPROM reads a little bit more breathing room
jamwaffles
added a commit
that referenced
this pull request
Nov 17, 2024
* Return `ReceiveAction` from `receive_frame` So we can filter out self-sent frames * Rewrite Windows TX/RX driver to use the `pcap` crate Massively improved performance (although Windows is still rubbish for RT stuff) * Add Windows example demonstrating some perf tweaks * Deprecate Windows `tx_rx_task` * Give EEPROM reads a little bit more breathing room
Merged
jamwaffles
added a commit
that referenced
this pull request
Nov 17, 2024
* Add a blocking Windows TX/RX function (#246) * Return `ReceiveAction` from `receive_frame` So we can filter out self-sent frames * Rewrite Windows TX/RX driver to use the `pcap` crate Massively improved performance (although Windows is still rubbish for RT stuff) * Add Windows example demonstrating some perf tweaks * Deprecate Windows `tx_rx_task` * Bump MSRV to 1.79 To fix `#[collapse_debuginfo(yes)]` issues in `embassy-time`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
tx_rx_taskso a backport to 0.5 will give warningsasync-spin-sleepand see what performance and CPU usage is like, with a mind to recommending it for applications that still requireasynctimers.