Support PDIs longer than a single frame can hold #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamwaffles
force-pushed
the
chunked-pdi-sends
branch
from
f09b249
to
a9359a4
Compare
… read" This reverts commit 0c9c5cd.
jamwaffles
force-pushed
the
chunked-pdi-sends
branch
from
668c3ba
to
f8b0d5e
Compare
It shows up a lot in multi-PDU sends when a new PDU overflows the frame. The error itself is handled elsewhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This chunks a SubDevice group's PDI and sends it over multiple Ethernet/EtherCAT frames if the allocated storage is too small to send the whole PDI in one PDU.
TODO
subdevice_group/mod.rs- there's a lot of bug-prone copypasta in thetx_rx_*methods.