Don't check returned counter in CoE responses #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SOEM doesn't do it, and the spec is extremely vague about what this value not being equal to what was sent means. Maybe there's some better stuff in the CANOpen spec, but I don't have access to it.
jamwaffles
added a commit
that referenced
this pull request
Sep 24, 2024
* Stop checking mailbox counter response value SOEM doesn't do it, and the spec is extremely vague about what this value not being equal to what was sent means. Maybe there's some better stuff in the CANOpen spec, but I don't have access to it. * Attempt to clear read mailbox up to 10 times * Retry mailbox clear multiple times
jamwaffles
added a commit
that referenced
this pull request
Sep 24, 2024
* Stop checking mailbox counter response value SOEM doesn't do it, and the spec is extremely vague about what this value not being equal to what was sent means. Maybe there's some better stuff in the CANOpen spec, but I don't have access to it. * Attempt to clear read mailbox up to 10 times * Retry mailbox clear multiple times
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A customer is seeing an issue where a CoE request is sent with
counter = 1, but is returned withcounter = 2. The response seems otherwise valid, with the expected index/subindex, so I'm not sure what's going on.This PR stops checking the returned counter value, and instead does some extra validation on the index/subindex to be more confident the response is to the request we sent.