Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Device name string handling improvements #232

Merged
merged 4 commits into from
Aug 14, 2024
Merged

Device name string handling improvements #232

merged 4 commits into from
Aug 14, 2024

Conversation

jamwaffles
Copy link
Collaborator

  • No longer uses static string index to read device name, fixing issues with SubDevices that have e.g. image data in index 1.
  • Adds {SubDevice,SubDeviceRef}::description() method to get longer device name
  • More gracefully handle non-ASCII characters in device name strings

@jamwaffles
Get name string index from EEPROM, add description method
a3ea520
@jamwaffles
Replace non-ASCII characters with '?'
b6eab47 
This was added to cater for the EL2262 I have, which uses ISO-8859-1
encoding. I believe this was fixed in later firmwares/EEPROM images, but
it's a failure mode we should handle nonetheless.
@jamwaffles
Recapture replay tests
7eecfa3
@jamwaffles
Changelog
0ce5cbc
@jamwaffles jamwaffles enabled auto-merge (squash) August 14, 2024 12:06
@jamwaffles jamwaffles merged commit 099bceb into master Aug 14, 2024
9 of 10 checks passed
@jamwaffles jamwaffles deleted the proper-device-strings branch August 14, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jamwaffles