Fix overflowing subtraction when calculating DC cycle offset #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamwaffles
force-pushed
the
next-iter-overflow
branch
2 times, most recently
from
fc5b70d
to
c9251c8
Compare
Co-Authored-By: Bartjan van der Meer <[email protected]>
jamwaffles
force-pushed
the
next-iter-overflow
branch
from
c9251c8
to
6702b9b
Compare
jamwaffles
force-pushed
the
next-iter-overflow
branch
from
dea4565
to
369bd69
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was originally fixed by @jabratn in this commit on their fork. I hope you don't mind me taking the fix! I've added the
Co-Authored-Byheader to give due credit.Tested on my EK1100 setup which panics on overflow when on
master, but doesn't on this branch (but still calculates the offset correctly).