Remove got/expected fields from WireError buffer size variants
#218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
text data bss dec hex filename 97096 112 57800 155008 25d80 ethercrab-stm32-embassy Roughly 8% slower in benchmarks though :(
text data bss dec hex filename 96820 112 57800 154732 25c6c ethercrab-stm32-embassy
text data bss dec hex filename 96788 112 57800 154700 25c4c ethercrab-stm32-embassy Down to about ~8% performance loss compared to `master`
text data bss dec hex filename 96668 112 57800 154580 25bd4 ethercrab-stm32-embassy
text data bss dec hex filename 96588 112 57800 154500 25b84 ethercrab-stm32-embassy
jamwaffles
changed the title
WireError buffer size variants
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And other small optimisations
master:This branch: