Only support ASCII strings in EEPROM #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
text data bss dec hex filename 98812 112 57800 156724 26434 ethercrab-stm32-embassy
text data bss dec hex filename 98764 112 57800 156676 26404 ethercrab-stm32-embassy
Increases binary size for some reason - maybe more inlining? text data bss dec hex filename 99812 112 57800 157724 2681c ethercrab-stm32-embassy
We only use them to calculate PDO bit length, so they don't need to be stored. text data bss dec hex filename 98856 112 57800 156768 26460 ethercrab-stm32-embassy
text data bss dec hex filename 97716 112 57800 155628 25fec ethercrab-stm32-embassy
text data bss dec hex filename 95852 112 57800 153764 258a4 ethercrab-stm32-embassy
text data bss dec hex filename 97496 112 57800 155408 25f10 ethercrab-stm32-embassy
No change in binary size, but nicer code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The EtherCAT spec ETG1000.4 section 5.2.6 defines a "Visible String" as the characters 0x20 to 0x7E. To conform with the spec, as well as reduce code size a bit due to not having to validate UTF-8, this PR will now make EEPROM string reads fail if the string is not ASCII.
Code size reduction from
master:To this branch: