Handle frame timeout logic in response future #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A slight reduction in binary size Master: ``` text data bss dec hex filename 99472 112 57800 157384 266c8 ethercrab-stm32-embassy ``` This commit: ``` text data bss dec hex filename 99316 112 57800 157228 2662c ethercrab-stm32-embassy ``` This change also results in a ~10% improvement in throughput with the `pdu_loop` benchmark.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As opposed to using a
forloop. This change results in a slight reduction in binary size which was the goal of the PR.Master:
This commit:
As well as a ~10% improvement in throughput in the
pdu_loopbenchmark as a nice bonus.