Relax Windows 'static TX/RX lifetime, fix some unwraps
#183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamwaffles
force-pushed
the
non-static-windows
branch
from
ae7b7cf
to
a9e9d2e
Compare
|
Tested with $env:RUST_LOG='info'; cargo run --release --example ek1100 '\Device\NPF_{5B67A9B1-06E7-48F6-B81C-9112ECF37235}'Test hardware is EK1100, EL2889, EL2828. The static DC sync is still slow as molasses as it has always been on Windows, but everything works as well as it did in Would be great if @Dirreke could confirm this branch is working on their side before I merge :) |
|
Thanks, I will test it later. |
|
It's OK to me. |
|
Great, thanks for testing! |
jamwaffles
added a commit
that referenced
this pull request
Mar 12, 2024
* Relax Windows `'static` TX/RX lifetime * Improve error handling for Windows TX/RX loop NOTE: This commit has been changed from the original PR a bit to make it work with 0.3.x.
jamwaffles
added a commit
that referenced
this pull request
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will merge into
master, which is the upcoming 0.4 release.A future PR will backport this to 0.3.x.