Improve behaviour when frames are still in flight #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this PR, if the frame slot at the
N + 1th index was still occupied, an error would occur. Now, the PDU loop storage code will loop through the entire slot space up to 2 times looking for a free slot to use.This mitigates situations where a frame from a previous cycle or another thread is still marked as in use (e.g. because its payload data is still held). Now, the PDU loop will skip over that slot and go looking for the next free one. Not a total fix, but much improved when testing with 11 threads - one tx/rx and 10 others running tasks simultaneously.
Also adds a bunch of logging.