Fix concurrent awaits #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Waking the future again to check if more frames are available is done in the no_std example, but was missing in `std`
|
Note: Tests are currently broken as the replay harness doesn't know how to handle traffic that isn't strictly req/res/req/res, etc. This PR changes things so multiple reqs can happen at a time. I'm going to merge even with broken tests as this fix is needed for some client code and I don't want to fix the tests right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A pretty simple fix all in all. It was caused by the
stdTX/RX future supplied by EtherCrab not re-waking itself to check if there are any more frames to receive. Adding actx.waker().wake_by_ref()in fixes thestatus()error case in #111.Closes #111