Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated feedback feature to support both email and GitHub options #28

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Updated feedback feature to support both email and GitHub options #28

wants to merge 1 commit into from

Conversation

jerielng
Copy link

@jerielng jerielng commented Dec 25, 2019

Details

  • Added functionality to submit feedback via both email and GitHub issue
  • Refactored URL options dictionary into SharedUtils class for reuse across other classes (DRY)

Screenshots

Simulator Screen Shot - iPhone 8 - 2019-12-26 at 02 04 15

@jerielng jerielng changed the title Updated feedback feature to support both email and GitHub options #25 Updated feedback feature to support both email and GitHub options Dec 25, 2019
@jerielng jerielng changed the title #25 Updated feedback feature to support both email and GitHub options Updated feedback feature to support both email and GitHub options Dec 25, 2019
@ethanhuang13
Copy link
Owner

Please submit changes in separated PRs.

@jerielng
Copy link
Author

Please submit changes in separated PRs.

Just updated to individual PRs. Kept the SharedUtils bundled together with these changes because the function convertToUIApplicationOpenExternalURLOptionsKeyDictionary is necessary and being called by the function that submits the GitHub issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants