AA-466: Require SenderCreator to be called from EntryPoint & AA-470: Make SenderCreator public #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the change is SenderCreator is not enough and not clear by itself: need to add |
drortirosh
reviewed
Dec 17, 2024
contracts/core/SenderCreator.sol
Outdated
| @@ -15,6 +21,9 @@ contract SenderCreator { | |||
| function createSender( | |||
| bytes calldata initCode | |||
| ) external returns (address sender) { | |||
| if (msg.sender != entryPoint) { | |||
| revert("AAxx should call from EntryPoint"); | |||
There was a problem hiding this comment.
this is not an expected error case to happen with entrypoint, only by "side-calling".
So it is an AA9x.
Can reuse "AA92 only from entrypoint"
There was a problem hiding this comment.
Didn't want to reuse error codes, defined it s AA97.
drortirosh
force-pushed
the
AA-466-AA-470-prevent-initcode-frontrun-and-make-sendercreator-public
branch
from
28745a7 to
1b8ff94
Compare
for some reason, it is doesn't work when called in "parallel"
drortirosh
force-pushed
the
AA-466-AA-470-prevent-initcode-frontrun-and-make-sendercreator-public
branch
from
5f4a937 to
aa5b03a
Compare
forshtat
changed the title
drortirosh
approved these changes
Dec 23, 2024
forshtat
deleted the
AA-466-AA-470-prevent-initcode-frontrun-and-make-sendercreator-public
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.