Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PBHSignatureAggregator #512

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

karankurbur
Copy link

@karankurbur karankurbur commented Dec 10, 2024

  • change interface to remove view modifier from validateSignatures and validateUserOpSignature. This is required since we may have state change inside PBHValidator
  • create PBHSignatureAggregator that inherit the BLSSignatureAggregator class
  • add new function to return encoded BLS signature + proofs array
  • modify the validateSignatures and validateUserOpSignature to remove the proof before verifying the BLS signature through the BLSSignatureAggregator
  • verify the proof through PBHVerifier

TODO:

  • Check E2E if modifying the interface reverts from EntryPoint
  • Unit tests to validate encoding/decoding logic
  • Refactor BLSSignatureAggregator to use created internal functions

@karankurbur karankurbur marked this pull request as draft December 10, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant