remove unused event PostOpReverted from TokenPaymaster #383
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing the event PostOpReverted which is not being used in current paymaster. I would also like to understand reason behind adding this in the entry point and how to use it in paymasters. (in context of current entry point and upcoming EP)
Adding this back in _postOp()
since current entry point still uses postOp twice and current code will just revert twice if postOp can not transfer tokens etc.
pre charging in validatePaymasterUserOp works but it's not a great UX to give pre approval to the paymaster as part of other userOp sponsored by some other paymaster. instead of that dapps would prefer limited approvals given as part of each calldata (based on fee quotes)
in new entry point with this it would change couple of things again regarding UX of token paymaster.