AA-222 add delegateAndRevert helper, to simulate code execution from entryPoint. #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drortirosh
force-pushed
the
AA-222-delegate-and-revert
branch
from
5a7ff61 to
73c5023
Compare
drortirosh
force-pushed
the
AA-222-delegate-and-revert
branch
from
62afc47 to
1d63ae2
Compare
forshtat
previously approved these changes
Dec 18, 2023
contracts/core/EntryPoint.sol
Outdated
|
|
||
| /// @inheritdoc IEntryPoint | ||
| function delegateAndRevert(bytes calldata data) external { | ||
| (bool success, bytes memory ret) = address(this).delegatecall(data); |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
contracts/interfaces/IEntryPoint.sol
Outdated
| * The method always revert, so is only useful off-chain for dry run calls, in cases where state-override to replace | ||
| * actual EntryPoint code is less convenient. | ||
| */ | ||
| function delegateAndRevert(bytes calldata data) external; |
There was a problem hiding this comment.
Is there a reason to have this method as part of the EntryPoint interface? I think this is just a temporary workaround and should not affect the interface at all.
There was a problem hiding this comment.
yes, we removed all opinionated "view" functions from the EntryPoint, since "state-override" allows using custom functionalities.
But in case state override doesn't exist, this is the minimum required code in entrypoint to allow running off-chain code from entrypoint address without causing any side-effect.
e.g. state-override is not supported by estimateGas, at least on some node implementations. Bundlers can overcome this by rapid RPC "eth_call" calls to the node which they are close to - but end-users can't.
shahafn
approved these changes
Dec 20, 2023
drortirosh
added a commit
that referenced
this pull request
Jan 3, 2024
…entryPoint. (#365) Minimal "static" call from EntryPoint to simulate special cases. Equivalent to the EntryPointSimulations in purpose, but doesn't require stateOverride. Executes code on behalf of entryPoint using delegateCall, and revert with the result
drortirosh
added a commit
that referenced
this pull request
Jan 7, 2024
…entryPoint. (#365) Minimal "static" call from EntryPoint to simulate special cases. Equivalent to the EntryPointSimulations in purpose, but doesn't require stateOverride. Executes code on behalf of entryPoint using delegateCall, and revert with the result
7 tasks
DemonBarber1020
added a commit
to DemonBarber1020/account-abstraction
that referenced
this pull request
Aug 23, 2024
* update validation rules * spellings * merge changes from davidinsuomi:update-eip-4337-description-paymater from external PR eth-infinitism#378 * AA-222 add delegateAndRevert helper, to simulate code execution from entryPoint. (eth-infinitism#365) Minimal "static" call from EntryPoint to simulate special cases. Equivalent to the EntryPointSimulations in purpose, but doesn't require stateOverride. Executes code on behalf of entryPoint using delegateCall, and revert with the result * TokenPaymaster "gas-calc" test (eth-infinitism#300) * Initial commit for TokenPaymaster "gas-calc" test * Deploy all TokenPaymaster contracts with Create2Factory for "gas-calc" * Make TestPaymaster use postOp * Storage-Optimization for TokenPaymaster - change gas and timestamps to 48 bits - change blanaces and multipliers to 128 bit - saves 10kgas (and since 10-op batch uses the same TokenPaymaster, the * add initial balance to paymaster * editorial changes by yoav Co-authored-by: Yoav Weiss <[email protected]> * review changes * merge fixes * more review fix * Apply suggestions from code review Co-authored-by: Yoav Weiss <[email protected]> * make sure innerHandleOp gets enough gas. (eth-infinitism#401) * make sure innerHandleOps gets enough gas. UserOperation's call must receive at least callGasLimit. If there isn't enough provided to handleOps, the bundle should revert. * address yoav PR comments * added EREP-015: paymaster opsSeen if failure caused by other entity * Fixing reputation rules * update ERCs (eth-infinitism#404) * update ERCs * Update erc/ERCS/erc-7562.md Co-authored-by: Yoav Weiss <[email protected]> * Fixing pr * Update erc-7562.md * Update erc-7562.md * Fixing merge * Update erc/ERCS/erc-7562.md Co-authored-by: Yoav Weiss <[email protected]> * Update erc-7562.md: fixed typo * Update erc-7562.md (eth-infinitism#405) --------- Co-authored-by: Dror Tirosh <[email protected]> Co-authored-by: Alex Forshtat <[email protected]> Co-authored-by: Yoav Weiss <[email protected]> Co-authored-by: shahafn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minimal "static" call from EntryPoint to simulate special cases. Equivalent to the EntryPointSimulations in purpose, but doesn't require stateOverride.
Executes code on behalf of entryPoint using
delegateCall, and revert with the result