Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eip: remove "increment nonce" clause #353

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Conversation

drortirosh
Copy link
Contributor

nonce is managed by entrypoint. account doesn't have to increment it.

nonce is managed by entrypoint. account doesn't have to increment it.
Copy link
Contributor

@yoavw yoavw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't have to increment the nonce, but maybe "optionally enforce nonce restrictions" instead?

E.g. require(key==0) for incremental nonces, or require(seq==0) for unordered replay protection.

@drortirosh
Copy link
Contributor Author

but maybe "optionally enforce nonce restrictions" instead?

there is a whole "Semi-abstracted Nonce Support" section. just removed obsolete mention to "increment" here.

@yoavw yoavw self-requested a review October 16, 2023 16:12
Copy link
Contributor

@yoavw yoavw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, following our discussion in the previous review.

@drortirosh drortirosh merged commit 73a6769 into develop Oct 16, 2023
8 checks passed
@drortirosh drortirosh deleted the eip-remove-inc-nonce branch October 16, 2023 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants