Adding try/except when running cli to remove stack traces #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remyroy
requested changes
Jun 25, 2024
ethstaker_deposit/deposit.py
Outdated
| try: | ||
| cli() | ||
| except (ValueError, ValidationError) as e: | ||
| click.echo(f"\nError: {e}\n") |
There was a problem hiding this comment.
The call to click.echo should include the following parameter here: err=True since this is an error. See https://click.palletsprojects.com/en/7.x/api/#click.echo
sys.exit(1) if catch called
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of showing a massive stack trace for thrown errors, we will now wrap the
cli()call and catch andValidatorErrororValueErrorand then display what the error is.To reproduce a stack traced ValidationError:
To reproduce a stack traced ValueError:
Fixes #18