New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add french japanese word list #68

Merged

remyroy merged 3 commits into eth-educators:main from valefar-on-discord:add-french-japanese-word-list

Jun 18, 2024

Collaborator

valefar-on-discord commented Jun 15, 2024

Adding French and Japanese mnemonic word lists
Updating mnemonic unit test test data to include data for French and Japanese which was generated with a BIP39 tool
Corrected the spelling of Romanian and Chinese in constants.py. Not sure if I am misunderstanding something here though...
Removing xprv data from mnemonic test data because it was not used in any form.

I did a few tests around generating and regenerating mnemonics and had no issues.

Fixes #36

valefar-on-discord added 3 commits

June 15, 2024 11:23


          Adding french and japanese mnemonic word lists

fb4884b


          Correct spelling of "Romanian" and "Chinese"

448c978


          Remove unused xprv from mnemonic test data

c7c451b

remyroy self-requested a review

June 18, 2024 01:53

remyroy approved these changes

View reviewed changes

Member

remyroy left a comment

Everything is good.

remyroy merged commit 68c04df into eth-educators:main

15 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet