Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve build workflow and release process #200

Merged
merged 10 commits into from
Oct 19, 2024

Conversation

remyroy
Copy link
Member

@remyroy remyroy commented Oct 11, 2024

What I did

  • Merged docker workflow into the build workflow
  • Added a job to create a draft release on successful build workflow
  • Added steps to automatically upload built assets from the build workflow
  • Added steps to automatically add the template to our release notes
  • Documented the new release process
  • Refactored the build-binaries job to avoid duplicating code or calls where it make sense
  • Automatically generate the binaries table in the release notes
  • Automatically generate the docker image table in the release notes
  • Made sure the new draft release has the correct version tag when triggered by adding a tag on the repo
  • Made sure that binary asset links are good after publishing the draft release

This is meant to further simplify and create a release process that is easy and less prone to errors.

Related issue

Somewhat related to #181 and the discussion we had with ToB

@remyroy
Copy link
Member Author

remyroy commented Oct 15, 2024

I've streamlined the release and build process in a way to make it even easier and mostly automated.

@remyroy remyroy marked this pull request as ready for review October 15, 2024 20:38
@remyroy remyroy marked this pull request as draft October 15, 2024 21:41
@remyroy
Copy link
Member Author

remyroy commented Oct 16, 2024

A lot of this PR is being testing on my other org/repo on https://github.com/remyroy-test/ethstaker-deposit-cli/ since you need the workflow files to be part of your main branch for them to be active and testable.

@remyroy remyroy force-pushed the improve-build-workflow branch from 504028f to e7dd1b6 Compare October 16, 2024 14:52
@remyroy
Copy link
Member Author

remyroy commented Oct 16, 2024

This should be ready for review now.

@remyroy remyroy marked this pull request as ready for review October 16, 2024 14:53
Copy link
Collaborator

@valefar-on-discord valefar-on-discord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Release notes modification is very nice

@valefar-on-discord valefar-on-discord merged commit 9fbf641 into eth-educators:main Oct 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants